Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38301 )
Change subject: timestamps: Fix syncing, logging and comments
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38301/1/src/lib/timestamp.c
File src/lib/timestamp.c:
https://review.coreboot.org/c/coreboot/+/38301/1/src/lib/timestamp.c@155
PS1, Line 155: printk(BIOS_INFO, "Timestamp - %s: %llu\n", timestamp_name(id), ts_time);
Also makes this output relative to the `base_time`.
Done
https://review.coreboot.org/c/coreboot/+/38301/1/src/lib/timestamp.c@223
PS1, Line 223: if (ts_cbmem_table->base_time == 0)
Well, the code looks odd anyway: Unconditionally migrate entries but […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38301
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia786c12c68c8921c0d09bc58a29fefdc72bf0c6d
Gerrit-Change-Number: 38301
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 09 Jan 2020 13:36:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment