Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/25389 )
Change subject: mb/google/poppy: Add variant for Atlas ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/25389/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/atlas/devicetree.cb:
https://review.coreboot.org/#/c/25389/1/src/mainboard/google/poppy/variants/... PS1, Line 8: DSX_EN_WAKE_PIN
Do we still need this? I thought we removed the wake line going to WAKE# pin.
it is still connected on atlas, though maybe it should be using a different pin for s0ix to work properly? I will check.
Since we aren't using DS3 these probably don't need to be enabled as wake pins anyway..