Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35799 )
Change subject: soc/intel/sgx: convert SGX and PRMRR devicetree options to Kconfig ......................................................................
Patch Set 12:
Patch Set 12:
Sorry for jumping into a review late. Is it too late to split this up? The `memmap.c` changes are an actual fix to the code base, are the fragile part that needs decent review _and_ are not covered by the commit message. All clear signs that they belong into a preceding commit.
Well, let's see if we get this splitted :-)
not covered by the commit message
They ARE covered (second parapraph), just not that deeply. I already splitted of, what Arthur suggested. What do you want to see moved to the previous commit? The remaining memmap changes are needed to make it configurable.
I could move the msr checks to another commit if you like.