Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33462 )
Change subject: riscv: fix run_payload
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/33462/2/src/arch/riscv/payload.c
File src/arch/riscv/payload.c:
https://review.coreboot.org/#/c/33462/2/src/arch/riscv/payload.c@44
PS2, Line 44: /* disable MMU */
why only disable MMU for S-Mode?
Shouldn't this always be done?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33462
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaab595f916949c57104ec00f8b06ea047fe76bba
Gerrit-Change-Number: 33462
Gerrit-PatchSet: 2
Gerrit-Owner: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Philipp Hug
philipp@hug.cx
Gerrit-CC: Shawn C
citypw@gmail.com
Gerrit-CC: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 14 Jun 2019 10:06:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment