Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41612 )
Change subject: util: Add spd_tools to generate SPDs for TGL boards
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41612/8/util/spd_tools/intel/lp4x/g...
File util/spd_tools/intel/lp4x/gen_spd.go:
https://review.coreboot.org/c/coreboot/+/41612/8/util/spd_tools/intel/lp4x/g...
PS8, Line 407: SPD_VALUE_BUS_WIDTH = 0x01
I had similar sentiments: we should drive the SoC expectations as a transformation of the main data […]
I haven't yet addressed this. Looking at the advisory to see what all differs between TGL and JSL. I agree that it would be better to <encode JSON as per datasheet with no SoC specific encodings> and then use that data to generate SPDs differently for different SoCs as required.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41612
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9b64d1d48371ccea1c01630a33a245d90f45214
Gerrit-Change-Number: 41612
Gerrit-PatchSet: 9
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Ron Minnich
rminnich@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 May 2020 07:15:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment