Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59245 )
Change subject: soc/mediatek/mt8186: Add support for PMIC MT6366 ......................................................................
Patch Set 3:
(3 comments)
File src/soc/mediatek/mt8186/mt6366.c:
https://review.coreboot.org/c/coreboot/+/59245/comment/29753c1b_73fea04d PS1, Line 174: };;
Statements terminations use 1 semicolon […]
Done
https://review.coreboot.org/c/coreboot/+/59245/comment/b2187da9_9b46c669 PS1, Line 606: printk(BIOS_WARNING, "%s: ID = %#x \n", __func__,
unnecessary whitespace before a quoted newline […]
Done
https://review.coreboot.org/c/coreboot/+/59245/comment/75a2d48d_b4df8514 PS1, Line 647: BUG();
Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
Please fix.