Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33448 )
Change subject: mb/google/octopus: rename get_board_sku and make it overridable ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33448/1/src/mainboard/google/octopus/mainboa... File src/mainboard/google/octopus/mainboard.c:
https://review.coreboot.org/#/c/33448/1/src/mainboard/google/octopus/mainboa... PS1, Line 121: __weak
I had suggested partners to refer how nami's implementation was and I support to leverage the same f […]
There is only one way to get the board sku on octopus platforms: cbi. There is no other way currently where a variant needs to change that behavior. The __weak was there for other platforms because there were multiple ways and workarounds required. For octopus designs there isn't a necessity for having multiple ways. The only change I see required is exposing it as global. I agree that consistency is good, but I think in this case the previous implementations needed overridable linkage because of transitions in design at the time and needing to support all those at once.