Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38920 )
Change subject: [WIP] mb/gigabyte: Add Gigabyte Z170X-Gaming 7
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38920/2/src/mainboard/gigabyte/ga-z...
File src/mainboard/gigabyte/ga-z170x-gaming7/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/38920/2/src/mainboard/gigabyte/ga-z...
PS2, Line 37: /* Intel, SkylakeHDMI */
Add a blank line between codecs for clarity
Done
https://review.coreboot.org/c/coreboot/+/38920/2/src/mainboard/gigabyte/ga-z...
File src/mainboard/gigabyte/ga-z170x-gaming7/mainboard.c:
PS2:
This should not be necessary at all for SKL.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38920
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2c69bddd22cbd8f797dbb57370a4d8e5afa63bc
Gerrit-Change-Number: 38920
Gerrit-PatchSet: 8
Gerrit-Owner: Christoph Pomaska
github@slrie.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christoph Pomaska
github@slrie.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Pavel Sayekat
Gerrit-Comment-Date: Sun, 16 Feb 2020 11:06:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment