Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44262 )
Change subject: soc/intel/tigerlake: move mainboard_silicon_init_params ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44262/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44262/2//COMMIT_MSG@10 PS2, Line 10: variant : specific devicetree overrides Where are these coming from? It's all compiled into one static.c/.h devicetree for each board
https://review.coreboot.org/c/coreboot/+/44262/2/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/44262/2/src/soc/intel/tigerlake/fsp... PS2, Line 96: mainboard_silicon_init_params(params); Why did this move? I was pretty sure the reason we had it at the end of the function is that it allows the mainboard to override any parameter that was set here, based on devicetree settings. This allows us to modify UPDs based on SKU-specific diffs.