Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Lean Sheng Tan, Tim Chu, Ziang Wang.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75741?usp=email )
Change subject: soc/intel/spr-sp: Remove HWP related settings
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75741/comment/cba4159c_f50f8036 :
PS1, Line 2: wanghao11
Please use your full name and not the user name:
$ git config --global user.name "Wang Hao" # if correct
$ git commit --amend --author="Wang Hao wanghao11@inspur.com" -s
https://review.coreboot.org/c/coreboot/+/75741/comment/ab260a93_7a6e4059 :
PS1, Line 11:
coreboot tries to be as much as independent from FSP as possible. What is the downside of doing this in coreboot (possible again)?
https://review.coreboot.org/c/coreboot/+/75741/comment/1e65aec5_8917ea0b :
PS1, Line 13: wanghao11
Ditto.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75741?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4ff63cbff0dffb4cd65fdfa814eda85964130ee
Gerrit-Change-Number: 75741
Gerrit-PatchSet: 1
Gerrit-Owner: Ziang Wang
ziang.wang@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Ziang Wang
ziang.wang@intel.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 09 Jun 2023 11:57:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment