Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35042 )
Change subject: mb/google/kahlee/treeya: Update STAPM parameters for Treeya ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35042/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35042/2//COMMIT_MSG@7 PS2, Line 7: Set
Update
Done
https://review.coreboot.org/c/coreboot/+/35042/2//COMMIT_MSG@9 PS2, Line 9: Tuning
Tune
Done
https://review.coreboot.org/c/coreboot/+/35042/2//COMMIT_MSG@9 PS2, Line 9: Tuning stapm percentage from 80 to 68 and time from 250 second : to 90 second make them meet Lenovo temperature spec.
Where did you get these values from?
Dear Paul, regarding these values, please kindly check ticket: 143859022, our thermal guy has replied. Thanks a lot!
https://review.coreboot.org/c/coreboot/+/35042/2//COMMIT_MSG@14 PS2, Line 14: meet
meets
Done