Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29490 )
Change subject: soc/intel/common: Add SSID header ......................................................................
Patch Set 13:
Even it is not fit for this situation, there's possibility that it may use internal register that expose the programming into coreboot? Overall we still want to protect vendor's IP?
Yes, but not primarily. I would say the primary objective is to make customers happy. This is best done with sane, maintainable code which may conflict vendor-IP protection.
That's against the training I have got, sorry I disagree with that.
What training? Intel training? OSS development training? coreboot training? ;)
Also, it depends much on the definition of IP. If you call it IP when Intel uses a lock or a non-standard register location, that would be against my training and I would have to disagree.