6 Feb
2021
6 Feb
'21
10:57 a.m.
Attention is currently required from: Nico Huber, Angel Pons, Patrick Rudolph. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49749 )
Change subject: nb/intel/haswell: Use common {DMI,EP,MCH}BAR accessors ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/northbridge/intel/haswell/haswell.h:
https://review.coreboot.org/c/coreboot/+/49749/comment/9d2a2c91_b231ff07 PS4, Line 64: EPBAR64 Is the reason for keeping those here, that older Intel NB don't have any EP/DMI 64bit registers?
--
To view, visit https://review.coreboot.org/c/coreboot/+/49749
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ff4577ce662697cb3d8fb34003217fd6275dd42
Gerrit-Change-Number: 49749
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Sat, 06 Feb 2021 10:57:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment