Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33448
Change subject: mb/google/octopus: rename get_board_sku and make it overridable ......................................................................
mb/google/octopus: rename get_board_sku and make it overridable
BUG=b:134912735 BRANCH=octopus TEST=emerge-octopus coreboot chromeos-bootimage Change-Id: I1fb7b5eeac48f2cd9c24fa1d3ac3fe4b390762d2 Signed-off-by: Kevin Chiu Kevin.Chiu@quantatw.com --- M src/mainboard/google/octopus/mainboard.c M src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h 2 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/33448/1
diff --git a/src/mainboard/google/octopus/mainboard.c b/src/mainboard/google/octopus/mainboard.c index 4316ffe..31a2fd1 100644 --- a/src/mainboard/google/octopus/mainboard.c +++ b/src/mainboard/google/octopus/mainboard.c @@ -118,7 +118,7 @@ #define SKU_UNKNOWN 0xFFFFFFFF #define SKU_MAX 255
-static uint32_t get_board_sku(void) +uint32_t __weak variant_board_sku(void) { static uint32_t sku_id = SKU_UNKNOWN;
@@ -134,7 +134,7 @@ const char *smbios_system_sku(void) { static char sku_str[7]; /* sku{0..255} */ - uint32_t sku_id = get_board_sku(); + uint32_t sku_id = variant_board_sku();
if ((sku_id == SKU_UNKNOWN) || (sku_id > SKU_MAX)) { printk(BIOS_ERR, "%s: Unexpected SKU ID %u\n", diff --git a/src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h index 9638118..1df6dea 100644 --- a/src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h @@ -34,7 +34,8 @@ const struct lpddr4_cfg *variant_lpddr4_config(void); /* Return memory SKU for the board. */ size_t variant_memory_sku(void); - +/* Return board SKU */ +uint32_t variant_board_sku(void); /* Return ChromeOS gpio table and fill in number of entries. */ const struct cros_gpio *variant_cros_gpios(size_t *num);