Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33839 )
Change subject: mb/protectli/vault_kbl: Add FW6 support ......................................................................
Patch Set 10: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/33839/10/src/mainboard/protectli/va... File src/mainboard/protectli/vault_kbl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/33839/10/src/mainboard/protectli/va... PS10, Line 100: .ac_loadline = 1030, : .dc_loadline = 1030, Can we use the values for these parameters from SoC code? as for Iccmax
https://github.com/coreboot/coreboot/blob/7a70a46ecc30decffbea0bb3ef8fee54b1...
https://review.coreboot.org/c/coreboot/+/33839/10/src/mainboard/protectli/va... File src/mainboard/protectli/vault_kbl/ramstage.c:
https://review.coreboot.org/c/coreboot/+/33839/10/src/mainboard/protectli/va... PS10, Line 26: params->GmmEnable = 0; disable it in the devicetree: device pci 08.0 off end # Gaussian Mixture Model
https://github.com/coreboot/coreboot/blob/23c1c4e153e8f1311b2e04a19a7e0c66d6...