[coreboot-gerrit] Change in ...coreboot[master]: arch/x86: Do not add properties to null DP packages

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32971 )

Change subject: arch/x86: Do not add properties to null DP packages
......................................................................

arch/x86: Do not add properties to null DP packages

It doesn't make sense to add a property to a non-existent Device
Property package. However, some of these functions will proceed anyway
and allocate a new Device Property package, add the property to
that, and then immediately leak the new package. This changes all the
acpi_dp_add_* functions to ignore a null package.

Change-Id: I664dcdbaa6b1b8a3aeb9a0126d622e2ffb736efd
Signed-off-by: Jacob Garber 
Found-by: Coverity CID 135745{6,7}, 138029{2-6}
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32971
Tested-by: build bot (Jenkins) 
Reviewed-by: Furquan Shaikh 
---
M src/arch/x86/acpi_device.c
1 file changed, 18 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved

diff --git a/src/arch/x86/acpi_device.c b/src/arch/x86/acpi_device.c
index 5d8777f..57fbc89 100644
--- a/src/arch/x86/acpi_device.c
+++ b/src/arch/x86/acpi_device.c
@@ -740,6 +740,9 @@
    const struct acpi_dp *prop;
    size_t i, properties_added = 0;

+	if (!dp || !property_list)
+		return 0;
+
    for (i = 0; i < property_count; i++) {
    	prop = &property_list[i];

@@ -775,6 +778,9 @@
 struct acpi_dp *acpi_dp_add_integer(struct acpi_dp *dp, const char *name,
    			    uint64_t value)
 {
+	if (!dp)
+		return NULL;
+
    struct acpi_dp *new = acpi_dp_new(dp, ACPI_DP_TYPE_INTEGER, name);

if (new)
@@ -786,6 +792,9 @@
 struct acpi_dp *acpi_dp_add_string(struct acpi_dp *dp, const char *name,
    			   const char *string)
 {
+	if (!dp)
+		return NULL;
+
    struct acpi_dp *new = acpi_dp_new(dp, ACPI_DP_TYPE_STRING, name);

if (new)
@@ -797,6 +806,9 @@
 struct acpi_dp *acpi_dp_add_reference(struct acpi_dp *dp, const char *name,
    			      const char *reference)
 {
+	if (!dp)
+		return NULL;
+
    struct acpi_dp *new = acpi_dp_new(dp, ACPI_DP_TYPE_REFERENCE, name);

if (new)
@@ -810,7 +822,7 @@
 {
    struct acpi_dp *new;

-	if (!child || child->type != ACPI_DP_TYPE_TABLE)
+	if (!dp || !child || child->type != ACPI_DP_TYPE_TABLE)
    	return NULL;

new = acpi_dp_new(dp, ACPI_DP_TYPE_CHILD, name);
@@ -826,7 +838,7 @@
 {
    struct acpi_dp *new;

-	if (!array || array->type != ACPI_DP_TYPE_TABLE)
+	if (!dp || !array || array->type != ACPI_DP_TYPE_TABLE)
    	return NULL;

new = acpi_dp_new(dp, ACPI_DP_TYPE_ARRAY, array->name);
@@ -842,7 +854,7 @@
    struct acpi_dp *dp_array;
    int i;

-	if (len <= 0)
+	if (!dp || len <= 0)
    	return NULL;

dp_array = acpi_dp_new_table(name);
@@ -862,6 +874,9 @@
    			 const char *ref, int index, int pin,
    			 int active_low)
 {
+	if (!dp)
+		return NULL;
+
    struct acpi_dp *gpio = acpi_dp_new_table(name);

if (!gpio)