Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41809 )
Change subject: lib/coreboot_table: Add Intel FSP version for cbmem to display ......................................................................
Patch Set 3:
(1 comment)
Patch Set 2:
(1 comment)
A solution without #if would be much preferred. All you need is an always available fsp_get_version() forward declaration. Then the call to lb_strings_fsp_version() can be guarded by a C `if`:
if (CONFIG(FSP_ADD_VERSION_TO_CBMEM)) lb_strings_fsp_version(head);
Done, thanks.
https://review.coreboot.org/c/coreboot/+/41809/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41809/2//COMMIT_MSG@9 PS2, Line 9: LB_TAG_EXTRA_VERSION
Please add a new tag. Existing software can be confused if this […]
Done