Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30118 )
Change subject: arch/x86/boot: Call payload in protected mode
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/#/c/30118/8/src/arch/x86/c_start.S
File src/arch/x86/c_start.S:
https://review.coreboot.org/#/c/30118/8/src/arch/x86/c_start.S@387
PS8, Line 387: push %rsp
This should be `push %rdx`, then restoration in setCodeSelectorLongJump32 is not required. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30118
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6552ac30f1b6205e08e16d251328e01ce3fbfd14
Gerrit-Change-Number: 30118
Gerrit-PatchSet: 14
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 29 Apr 2019 15:04:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-MessageType: comment