Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56273 )
Change subject: soc/amd/picasso: add missing banks to mca_bank_name array ......................................................................
soc/amd/picasso: add missing banks to mca_bank_name array
Also use array indices for the initialization.
TEST=Checked with the public Picasso PPR #55570-B1 Rev 3.16
Change-Id: I10a65210da73e64b67d613609fcc0f9a245a81fb Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/picasso/mca.c 1 file changed, 23 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/56273/1
diff --git a/src/soc/amd/picasso/mca.c b/src/soc/amd/picasso/mca.c index 23d7b61..69864a5 100644 --- a/src/soc/amd/picasso/mca.c +++ b/src/soc/amd/picasso/mca.c @@ -135,14 +135,29 @@ }
static const char *const mca_bank_name[] = { - "Load-store unit", - "Instruction fetch unit", - "L2 cache unit", - "Decode unit", - "", - "Execution unit", - "Floating point unit", - "L3 cache unit" + [ 0] = "Load-store unit", + [ 1] = "Instruction fetch unit", + [ 2] = "L2 cache unit", + [ 3] = "Decode unit", + [ 4] = "", + [ 5] = "Execution unit", + [ 6] = "Floating point unit", + [ 7] = "L3 cache unit", + [ 8] = "L3 cache unit", + [ 9] = "L3 cache unit", + [10] = "L3 cache unit", + [11] = "L3 cache unit", + [12] = "L3 cache unit", + [13] = "L3 cache unit", + [14] = "L3 cache unit", + [15] = "UMC", + [16] = "UMC", + [17] = "SMU", + [18] = "PSP", + [19] = "PB", + [20] = "CS", + [21] = "CS", + [22] = "PIE", };
static void mca_print_error(unsigned int bank)