Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46034 )
Change subject: drivers/wifi/generic: Add support for generating SMBIOS data ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46034/1/src/drivers/wifi/generic/ge... File src/drivers/wifi/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/46034/1/src/drivers/wifi/generic/ge... PS1, Line 248: smbios_write_intel_wifi
I am not really sure if this is still required. It was added ~6 years back(https://review.coreboot. […]
Maybe it means something to Windows?
https://review.coreboot.org/c/coreboot/+/46034/1/src/drivers/wifi/generic/ge... PS1, Line 279: return 0;
What does returning 0 mean here? no-op or error? elog_add_event_wake returns a positive length.
Should just mean that nothing was written.