Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38920 )
Change subject: [WIP] mb/gigabyte: Add Gigabyte Z170X-Gaming 7 ......................................................................
Patch Set 13:
(5 comments)
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... File src/mainboard/gigabyte/ga-z170x-gaming7/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 35: @0x280-0x2ff Please correct this I/O range in the comment and add here all the ranges that you use.
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 43: # Enable DPTF : register "dptf_enable" = "1"
Done
Why should this be disabled?
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 53: Display_PEG
Couldnt find any entries that give another sample on what to put into that field so I just removed i […]
Display_PEG means that if you use an external graphics card on your board and it is inserted into the PEG slot, the video will be output through it. If you disconnect the graphics card, the video will be output through IGD.
This option sets only priority, however, if you set Display_IGD here, only this device will be used, regardless of the external gfx.
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 243: Root port 7(x1) I see much more PCIe slots on the "Z170X-Gaming 7" motherboard (https://thunderbolttechnology.net/sites/default/files/imagecache/product-det...). Will you add them later?
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... File src/mainboard/gigabyte/ga-z170x-gaming7/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 29: DP2, -- The board's HDMI port
You need HDMI1 and HDMI2
One of them is DP. https://www.gigabyte.com/FileUpload/Product/2/5481/20150722181813_src.png