Attention is currently required from: Jason Glenesk, Raul Rangel, Felix Held.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52584 )
Change subject: soc/amd/cezanne,common,picasso: use BERT region reserved by FSP driver
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52584/comment/70e464a5_2ab6988e
PS4, Line 19: access it.
I think Felix was simply saying that he's _still_ able to access the region after the changes. The approach didn't change much, i.e. the region is still above cbmem.
What changed? Was the initial diagnosis wrong?
However, this is an interesting topic. CB:49799 is fairly modern and seems to put Intel's BERT table into cbmem. I don't understand how that should work; haven't looked to see whether the driver's been updated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52584
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaca89b47793bf9982181560f026459a18e7db134
Gerrit-Change-Number: 52584
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 20 May 2021 12:26:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment