Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48494 )
Change subject: soc/inte/common: Replace #if macro with if C-language constuct
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48494/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/48494/1/src/soc/intel/common/block/...
PS1, Line 33: "
If we add SOC_INTEL_CSE_RW_UPDATE flag as dependent, then we have to introduce #if macros in the CSE […]
I am referring to the prompt only. Not to the config option. Adding it to the prompt will ensure that it is not visible in menuconfig. But, it is still defined and allows you to drop the #if macros.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48494
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iecd5cf56ecd280de920f479e174762fe6b4164b0
Gerrit-Change-Number: 48494
Gerrit-PatchSet: 1
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 10 Dec 2020 20:20:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment