[coreboot-gerrit] [M] Change in coreboot[main]: drivers/intel/gma/opregion: Use CBFS cache to load VBT

[Nico Huber (Code Review)]

Attention is currently required from: Arthur Heymans, Eran Mitrani, Jakub Czapiga, Jérémy Compostella, Kapil Porwal, Nick Vaccaro, Tarun.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77886?usp=email )

Change subject: drivers/intel/gma/opregion: Use CBFS cache to load VBT
......................................................................

Patch Set 33:

(1 comment)

File src/drivers/intel/gma/opregion.c:

https://review.coreboot.org/c/coreboot/+/77886/comment/7e0b7468_3019f356 :
PS4, Line 27: cbfs_map
> Yes, it's pretty common practice to leak when necessary (e.g. […]

I find this quite confusing. The way you describe it, I see no difference to
using malloc() and leaking. Only that we have to fear another heap that might
be too small for some combinations of options. If it's like the generic heap,
why have it separate?

More on topic, was this tested sufficiently? that the cache is usually big enough?