Attention is currently required from: Tarun Tuli, Subrata Banik, Paul Menzel, Kapil Porwal.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74620 )
Change subject: soc/intel/common: Support power limits update for variants
......................................................................
Patch Set 8:
(2 comments)
File src/soc/intel/common/block/power_limit/power_limit.c:
https://review.coreboot.org/c/coreboot/+/74620/comment/843582fd_59d5d019
PS7, Line 237: #if CONFIG(SOC_INTEL_COMMON_BLOCK_VARIANT_POWER_LIMIT)
It's added to prevent building this new code base for older platforms. […]
Here the intention behind adding this new guard is to prevent building this new function code base for older platforms.
So, we might not need this at the caller. We need this guard here only.
https://review.coreboot.org/c/coreboot/+/74620/comment/b38cfc03_2cc83ae2
PS7, Line 241: if (!num_entries)
: return;
did u missed to submit a CL bt marked ACK?
Yes. Submitted new patch set for review now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74620
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I414715f211d816bbfad03a673ca96dd5df94caeb
Gerrit-Change-Number: 74620
Gerrit-PatchSet: 8
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: AlanKY Lee
alanky_lee@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Thu, 18 May 2023 10:32:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment