Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46432 )
Change subject: security/vboot: Make mrc_cache hash functions generic
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46432/10/src/security/vboot/secdata...
File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/46432/10/src/security/vboot/secdata...
PS10, Line 171: } else {
But we still need to correctly accommodate the non-recovery case here right (even though the index d […]
That would have to be done where you actually introduce the index. This should really get called only for recovery case at this point in the patch train.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46432
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c0bb25eafc731ca9c7a95113ab940f55997fc0f
Gerrit-Change-Number: 46432
Gerrit-PatchSet: 12
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 16 Oct 2020 23:33:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment