Attention is currently required from: Paul Menzel. Tim Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48946 )
Change subject: mb/ocp/deltalake: Override DDR frequency limit via VPD variable ......................................................................
Patch Set 10:
(5 comments)
This change is ready for review.
File src/mainboard/ocp/deltalake/romstage.c:
https://review.coreboot.org/c/coreboot/+/48946/comment/9b8f477d_1bf76713 PS7, Line 84: * 0xf:DDR_2666, 0x11:DDR_2933, 0x13:DDR_3200
Please use macros or enums.
Done
https://review.coreboot.org/c/coreboot/+/48946/comment/4a4eae23_07e5ce9d PS7, Line 88: > ARRAY_SIZE(limit) - 1
Use >= instead of - 1?
Use switch-case to replace.
https://review.coreboot.org/c/coreboot/+/48946/comment/aca148d3_2fafc66b PS7, Line 89: BIOS_DEBUG
This should be at least a warning, even an error?
Done
https://review.coreboot.org/c/coreboot/+/48946/comment/d9ed975c_60af6367 PS7, Line 93: BIOS_DEBUG
Maybe: BIOS_INFO
Done
https://review.coreboot.org/c/coreboot/+/48946/comment/56d4a927_4ad04afb PS7, Line 96: BIOS_INFO
Warning level?
Done