Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35235 )
Change subject: soc/intel/cannonlake: memory spd data debug ......................................................................
soc/intel/cannonlake: memory spd data debug
Add printing SPD data for debug usage.
BUG=b:139397313 BRANCH=N/A TEST=Tested the on Hatch and checked cbmem log.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I1e257a8ea6ff9c906267841819d2a4b62a9e0b9e Reviewed-on: https://review.coreboot.org/c/coreboot/+/35235 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/soc/intel/cannonlake/cnl_memcfg_init.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/soc/intel/cannonlake/cnl_memcfg_init.c b/src/soc/intel/cannonlake/cnl_memcfg_init.c index d3e5e83..6c551ad 100644 --- a/src/soc/intel/cannonlake/cnl_memcfg_init.c +++ b/src/soc/intel/cannonlake/cnl_memcfg_init.c @@ -81,6 +81,7 @@ default: die("nonexistent memory slot"); } + printk(BIOS_INFO, "memory slot: %d configuration done.\n", mem_slot); }
/* @@ -112,6 +113,7 @@
spd_data_ptr = (uintptr_t)rdev_mmap_full(&spd_rdev); last_spd_index = spd_index; + print_spd_info((unsigned char *)spd_data_ptr); }
meminit_spd_data(mem_cfg, mem_slot, spd_data_len, spd_data_ptr);