Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45952 )
Change subject: soc/intel/common: add Kconfig to enable/disable the ACPI PM timer ......................................................................
Patch Set 24:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45952/21//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45952/21//COMMIT_MSG@21 PS21, Line 21: Note: On Apollolake USE_PM_ACPI_TIMER gets selected statically to avoid : confusing the user in menuconfig, where the option is shown due to use : of the common code for PM Timer emulation. On APL there is not hardware : PM ACPI Timer, so emulation needs to be always enabled. :
needs rework, when we decide to hide USE_PM_ACPI_TIMER somehow
Done
https://review.coreboot.org/c/coreboot/+/45952/21/src/soc/intel/apollolake/K... File src/soc/intel/apollolake/Kconfig:
https://review.coreboot.org/c/coreboot/+/45952/21/src/soc/intel/apollolake/K... PS21, Line 108: select USE_PM_ACPI_TIMER
hmm... […]
Done
https://review.coreboot.org/c/coreboot/+/45952/21/src/soc/intel/common/block... File src/soc/intel/common/block/pmc/Kconfig:
https://review.coreboot.org/c/coreboot/+/45952/21/src/soc/intel/common/block... PS21, Line 46: Disabling it enables the ACPI timer emulation in microcode
this is not true anymore
Done