Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44893 )
Change subject: mb/google/zork: update GPIO config for berknip
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44893/3/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/berknip/gpio.c:
https://review.coreboot.org/c/coreboot/+/44893/3/src/mainboard/google/zork/v...
PS3, Line 49: /* PEN_DETECT_ODL - no used */
: PAD_NC(GPIO_4),
these 2 lines need a tab for indention.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44893
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d9b711ce1d7300181fe496d490dd33b38bc5983
Gerrit-Change-Number: 44893
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 28 Aug 2020 03:57:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment