build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38423 )
Change subject: cbfs: Add metadata cache ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38423/2/src/lib/cbfs.c File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/38423/2/src/lib/cbfs.c@58 PS2, Line 58: if (!(cbd = cbfs_get_boot_device(true))) do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/38423/2/src/lib/cbfs.c@309 PS2, Line 309: if (cbmem_possibly_online() && do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/38423/2/src/security/vboot/vboot_lo... File src/security/vboot/vboot_loader.c:
https://review.coreboot.org/c/coreboot/+/38423/2/src/security/vboot/vboot_lo... PS2, Line 111: if (cbmem_possibly_online() && do not use assignment in if condition