30 Nov
2022
30 Nov
'22
5:27 a.m.
Attention is currently required from: Subrata Banik, Nick Vaccaro.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69639 )
Change subject: mb/google/brya/acpi: Update NVPCF_FUNC_UPDATE_DYNAMIC_PARAMS ......................................................................
Patch Set 9:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69639/comment/64f12342_9c88be58 PS6, Line 22: D
Is that "D" a typo? Looks like this comment needs updating to match your latest patchset.
It is a Dword (4 byte) but the upper bits are reserved as 0 only.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69639
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69b80f4af2ecef6cf91034fc15fb6e8715eeca4f
Gerrit-Change-Number: 69639
Gerrit-PatchSet: 9
Gerrit-Owner: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Comment-Date: Wed, 30 Nov 2022 13:27:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro nvaccaro@google.com
Gerrit-MessageType: comment