Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37972 )
Change subject: src/Kconfig: enable USE_BLOBS by default
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37972/4/util/abuild/abuild
File util/abuild/abuild:
https://review.coreboot.org/c/coreboot/+/37972/4/util/abuild/abuild@723
PS4, Line 723: CONFIG_FSP_USE_REPO=y\n
CONFIG_FSP_USE_REPO sneaked through the rebase, I guess.
https://review.coreboot.org/c/coreboot/+/37972/4/util/abuild/abuild@723
PS4, Line 723: configoptions="${configoptions}CONFIG_USE_AMD_BLOBS=y\nCONFIG_ADD_FSP_BINARIES=y\nCONFIG_FSP_USE_REPO=y\n"
Ack
USE_AMD_BLOBS is actually USE_BLOBS with a license to ack before something
is downloaded. As blob licenses go, it's not a bad one. But would still have
to change if we wanted a default y there.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37972
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia0632b9ae7a1f212a8640b3faec2695d17d238c5
Gerrit-Change-Number: 37972
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 09 Apr 2020 21:55:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Christian Walter
christian.walter@9elements.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment