Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Michał Kopeć, Paul Menzel. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59548 )
Change subject: mb/clevo/tgl-u: add new board L14xMU ......................................................................
Patch Set 16:
(6 comments)
File src/mainboard/clevo/tgl-u/variants/l140mu/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144896): https://review.coreboot.org/c/coreboot/+/59548/comment/136ca143_524724e0 PS16, Line 94: PAD_CFG_NF(GPP_C18, NONE, DEEP, NF1), /* I2C1_SDA / PCH_I2C_SDA (retimer rom) */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144896): https://review.coreboot.org/c/coreboot/+/59548/comment/559c49f5_23c864c1 PS16, Line 95: PAD_CFG_NF(GPP_C19, NONE, DEEP, NF1), /* I2C1_SCL / PCH_I2C_SCL (retimer rom) */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144896): https://review.coreboot.org/c/coreboot/+/59548/comment/cf00604c_3d58a8e3 PS16, Line 99: PAD_NC(GPP_C23, UP_20K), /* GPP_C23 / PCH_GPP_C23 (WLAN_WAKEUP#) */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144896): https://review.coreboot.org/c/coreboot/+/59548/comment/440dfffd_d62a42db PS16, Line 104: PAD_NC(GPP_D2, NONE), /* LEDKB_DET# (unused; not sold w/o KBLED) */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144896): https://review.coreboot.org/c/coreboot/+/59548/comment/ca348cb5_d66ac0e7 PS16, Line 107: PAD_CFG_NF(GPP_D5, NONE, DEEP, NF1), /* SRCCLKREQ0# / SSD1_CLKREQ# (for SSD2!) */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144896): https://review.coreboot.org/c/coreboot/+/59548/comment/f9e4d852_cdb1ea4e PS16, Line 110: PAD_CFG_NF(GPP_D8, NONE, DEEP, NF1), /* SRCCLKREQ3# / SSD2_CLKREQ# (for SSD1!) */ line over 96 characters