Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38623 )
Change subject: hatch/mushu: Fix FPMCU pwr/rst gpio handling ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38623/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/hatch/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/38623/2/src/mainboard/google/hatch/... PS2, Line 25: ramstage-y += ramstage.c FYI these can go on one line
https://review.coreboot.org/c/coreboot/+/38623/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/hatch/ramstage.c:
https://review.coreboot.org/c/coreboot/+/38623/2/src/mainboard/google/hatch/... PS2, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright 2020 Google LLC : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ I believe coreboot is trying to (slowly) move over to SPDX headers, a la:
/* * This file is part of the coreboot project. * * Copyright 2020 The coreboot project Authors. * * SPDX-License-Identifier: GPL-2.0-or-later */