Attention is currently required from: Nico Huber, Martin Roth, Matt DeVillier, Andy Pont, Paul Menzel, Stefan Reinauer, Angel Pons.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56223 )
Change subject: payloads/external/tianocore: Add build argument for 4G Decode
......................................................................
Patch Set 19:
(1 comment)
File payloads/external/tianocore/Kconfig:
https://review.coreboot.org/c/coreboot/+/56223/comment/24bfa443_eaaf26af
PS16, Line 86: bool "Avoid above 4G memory"
: default n
: help
: Select this option to not reserve memory above 4G. This will allow
: the payload to use all of the memory.
How does it work if Above4GDecode() is not called? What is
providing the HOB in that case?
Nothing, which means DXE can do what it wants and use all the memory.
That there are so many BIOSes that use "Above 4G decoding" in
a very different sense will most likely confuse people.
Not going to disagree with that, but that seems to be down to the translations more than anything. Two platforms I have acccess too group a bunch of settings under "Above 4G MMIO" with a help text of "Above 4G Decoding". That one setting controls MMIO, Page Tables, memory recovery and a ludicrously over-complicated equivalant of this patch.
Is there an alternative you're suggesting? Something like EFICompatbilityMode would be much simpler, but only add to the mix of inconsitent terms.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56223
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3b1d15196c0ec611431af29031682fea626d19d
Gerrit-Change-Number: 56223
Gerrit-PatchSet: 19
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andy Pont
andy.pont@sdcsystems.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 27 Jul 2021 21:06:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Sean Rhodes
admin@starlabs.systems
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Andy Pont
andy.pont@sdcsystems.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment