build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37108 )
Change subject: cpu,soc/intel: Refactor em64t101 SMI handlers
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37108/4/src/cpu/intel/smm/smm_reloc...
File src/cpu/intel/smm/smm_reloc.c:
https://review.coreboot.org/c/coreboot/+/37108/4/src/cpu/intel/smm/smm_reloc...
PS4, Line 128: }
void function return statements are not generally useful
https://review.coreboot.org/c/coreboot/+/37108/4/src/cpu/intel/smm/smmreloca...
File src/cpu/intel/smm/smmrelocate_cpu_save.c:
https://review.coreboot.org/c/coreboot/+/37108/4/src/cpu/intel/smm/smmreloca...
PS4, Line 55: } else {
else is not generally useful after a break or return
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37108
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I177ca3b2966ccd985d72749ea2bd096ec4f233d6
Gerrit-Change-Number: 37108
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 22 Nov 2019 05:50:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment