Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32880 )
Change subject: soc/fsp_broadwell_de: fix flashconsole support for platform ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
What’s the status of this change-set?
I was waiting on a consensus on whether to revert the sb/common/spi version to using CAR global, or to use this patchset
Hey Matt. I would like to get that done, it rots too long already. What would be your preference? Keep the specific file for broadwell-de or go back to the common driver and enable early SPI there? @Kyösti: You might have a better history knowledge on the CAR_GLOBAL issues that have led to this inconsistence?
Oh.. still not solved? I think I commented somewhere partial revert on CB:30506 would be my choice of solution.
CAR_GLOBAL is to be deprecated with next release, so if you don't act fast the solution will appear in 4.10 branch only.
Somewhat related; any news from Intel about FSP1.0/1.1 to FSP2.0 updates?
That would be my prefferred solution, too. Matt, will you do it or shall I take care about the partial revert?
It basically drops down to revert the most of commit f751aee9268a8fe1840873ae72ed06a1cfeebf5e