Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48571 )
Change subject: soc/intel/skylake: Drop unreferenced devicetree settings ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48571/2/src/soc/intel/skylake/chip.... File src/soc/intel/skylake/chip.h:
https://review.coreboot.org/c/coreboot/+/48571/2/src/soc/intel/skylake/chip.... PS2, Line 510: FastPkgCRampDisable /cb-build/coreboot-gerrit.0/default/GOOGLE_CAROLINE/mainboard/google/glados/static.c:167:3: error: 'const struct soc_intel_skylake_config' has no member named 'FastPkgCRampDisable'; did you mean 'FastPkgCRampDisableIa'? .FastPkgCRampDisable = 0,