Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31108 )
Change subject: sb/intel/common/firmware: Don't call GbE binary `firmware` ......................................................................
Patch Set 1:
(1 comment)
As per Intel document this region holds "Lan FW + MAC address".
do you think " Don't call GbE binary `firmware`" is justified
here ?
Yes, pretty much justified.
As per Intel document, this region is described as follows:
The NVM image contains both static and dynamic data. The static data is the basic platform configuration, and includes OEM specific configuration bits as well as the unique Printed Circuit Board Assembly (PBA). The dynamic data holds the product’s Ethernet Individual Address (IA) and Checksum. This file can be created using a text editor.
Doesn't sound anything like firmware to me. That's from "Intel ® 82579 Gigabit Ethernet PHY Datasheet v2.1" btw.
Its beyond what it sounds to you. Please give a line from document that tell you its not FW region.
I'm referring to doc 550696.
this Kconfig meant to pack GBE region using IFD tool and i could see all over its been refer as GBE FW. Hence there could be 2 things.
1. All document is wrong where it refers as gbe fw should be gbe configuration 2. get clarification till the moment hold off this CL