[coreboot-gerrit] Change in ...coreboot[master]: [RFC]lib/coreboot_tables: Introduce BOOT_MEDIA_PARAMS2

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33107 )

Change subject: [RFC]lib/coreboot_tables: Introduce BOOT_MEDIA_PARAMS2
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33107/1/src/lib/coreboot_table.c 
File src/lib/coreboot_table.c:

https://review.coreboot.org/#/c/33107/1/src/lib/coreboot_table.c@328 
PS1, Line 328: off
This is assuming the address returned by rdev_mmap() is a physical address. That may be true now, but nothing guarantees that in the API. I see you have a FIXME above, but it's a big assumption on implementation in various places.