Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39002 )
Change subject: [TESTME]lib/edid_fill_fb: Support multiple framebuffers
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39002/2/src/include/framebuffer_inf...
File src/include/framebuffer_info.h:
https://review.coreboot.org/c/coreboot/+/39002/2/src/include/framebuffer_inf...
PS2, Line 25: edid_
EDID is about the modeline (hardware interface) while the framebuffer […]
Done
https://review.coreboot.org/c/coreboot/+/39002/2/src/include/framebuffer_inf...
PS2, Line 26: struct edid_fb_info *fb_new_framebuffer_info(void);
Could we make this part of fb_fill_framebuffer_info*()? […]
Introduced fb_set_framebuffer_info
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39002
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7264c2ea2f72f36adfd26f26b00e3ce172133621
Gerrit-Change-Number: 39002
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Alexandru Gagniuc
alexandrux.gagniuc@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 20 Feb 2020 09:05:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment