Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30510 )
Change subject: soc/intel/apollolake: Don't use CAR_GLOBAL ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/30510/4/src/soc/intel/apollolake/mmap_boot.c File src/soc/intel/apollolake/mmap_boot.c:
https://review.coreboot.org/#/c/30510/4/src/soc/intel/apollolake/mmap_boot.c... PS4, Line 88: real_dev_ptr = &real_dev; No point wrapping these to _ptr aliases?
https://review.coreboot.org/#/c/30510/4/src/soc/intel/apollolake/mmap_boot.c... PS4, Line 125: real_dev_ptr = &real_dev; As above, no point for _ptr alias?