Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33040 )
Change subject: sb/intel/bd82x6x: Use common final SPI OPs setup
......................................................................
Patch Set 13:
(1 comment)
Patch Set 12: Code-Review-1
-1 to call attention to Nico's comment.
https://review.coreboot.org/c/coreboot/+/33040/12/src/southbridge/intel/bd82...
File src/southbridge/intel/bd82x6x/lpc.c:
https://review.coreboot.org/c/coreboot/+/33040/12/src/southbridge/intel/bd82...
PS12, Line 878: {
call spi_finalize_ops() ?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33040
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I534e989279d771ec4c0249af325bc3b30a661145
Gerrit-Change-Number: 33040
Gerrit-PatchSet: 13
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 24 Sep 2019 12:08:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment