Attention is currently required from: Furquan Shaikh, Martin Roth, Andy Yeh, Sugnan Prabhu S, Rizwan Qureshi, Karthik Ramasubramanian.
Andy Yeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50261 )
Change subject: mb/google/dedede/var/magolor: Select camera module based on SSFC value
......................................................................
Patch Set 10: Code-Review+1
(1 comment)
File src/mainboard/google/dedede/variants/magolor/camera_config.c:
https://review.coreboot.org/c/coreboot/+/50261/comment/76bba8ae_87736a2c
PS9, Line 47: static struct drivers_intel_mipi_camera_config ovti5675_driver_info = {
@Andy to confirm if there are any plans for picking a 3rd camera source. […]
No 3rd camera source so far on Magolor. So we cannot verify the module with different power sequence on this DUT either. If there will be, we should have the confidence to implement the power sequence separation flow.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50261
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I764abf70bacbe61452e7b0fd59c1b375227b5748
Gerrit-Change-Number: 50261
Gerrit-PatchSet: 10
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Andy Yeh
Gerrit-Reviewer: Andy Yeh
andy.yeh@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: ShawnX Tu
shawnx.tu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Henry Sun
henrysun@google.com
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Andy Yeh
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 15 Apr 2021 07:29:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment