Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41385 )
Change subject: soc/intel/tigerlake: Move PMC PCI resources under PMC device ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41385/2/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chip.c:
https://review.coreboot.org/c/coreboot/+/41385/2/src/soc/intel/tigerlake/chi... PS2, Line 155: pmc_ops could you set .init = pmc_init here and have it be executed instead of needing the BOOT_STATE_INIT_ENTRY?
https://review.coreboot.org/c/coreboot/+/41385/2/src/soc/intel/tigerlake/pmc... File src/soc/intel/tigerlake/pmc.c:
https://review.coreboot.org/c/coreboot/+/41385/2/src/soc/intel/tigerlake/pmc... PS2, Line 94: soc_pmc_read_resources this ended up between pmc_init() and it's BOOT_STATE_INIT_ENTRY(), not necessarily a problem but usually good to keep those together.
Maybe doesn't matter if you could get rid of the BOOT_STATE_INIT_ENTRY entirely.