Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32373 )
Change subject: rockchip: rk3399: increase heap and memory for fit payload.
......................................................................
Patch Set 1:
I don't think the Kconfig change belongs here since there's nothing Rockchip-specific about it... it's just that the FIT code may use a lot more heap than the coreboot default expects.
How about we just change src/Kconfig to read
config HEAP_SIZE
hex
default 0x100000 if FLATTENED_DEVICE_TREE
default 0x4000
? Then it works for all boards that enable FIT support out of the box.
You can still submit a separate change to increase the ramstage in rk3399's memlayout, that doesn't hurt anyone.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32373
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee0ed9f7958588ceda54bb32253c84cac68abea2
Gerrit-Change-Number: 32373
Gerrit-PatchSet: 1
Gerrit-Owner: Marty E. Plummer
hanetzer@startmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lin Huang
hl@rock-chips.com
Gerrit-Reviewer: Marty E. Plummer
hanetzer@startmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shunqian Zheng
zhengsq@rock-chips.com
Gerrit-Reviewer: Ting Shen
phoenixshen@google.com
Gerrit-Reviewer: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: nickey yang
nickey.yang@rock-chips.com
Gerrit-Comment-Date: Mon, 22 Apr 2019 19:46:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment