Attention is currently required from: Jakub Czapiga, Tim Wawrzynczak.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62921 )
Change subject: commonlib/bsd/helpers: Move STRINGIFY() from string.h
......................................................................
Patch Set 2:
(1 comment)
File src/commonlib/bsd/include/commonlib/bsd/helpers.h:
https://review.coreboot.org/c/coreboot/+/62921/comment/7fca6c6a_2727c19e
PS2, Line 15: #define ALIGN(x, a) __ALIGN_MASK(x, (__typeof__(x))(a)-1UL)
ALIGN(), ALIGN_UP(), GiB, etc. […]
Right... now that we integrated commonlib/bsd into libpayload, we should be deduplicating those macros. Can you #include <commonlib/bsd/helpers.h> from <libpayload.h> and remove the duplicate libpayload versions (in another patch before this one)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62921
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3263b2aa7657759207bf6ffda750d839e741f99c
Gerrit-Change-Number: 62921
Gerrit-PatchSet: 2
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Mon, 21 Mar 2022 18:37:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Gerrit-MessageType: comment