Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35239 )
Change subject: hatch: automate creating a new variant in coreboot ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35239/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/scripts/create_coreboot_variant.sh:
https://review.coreboot.org/c/coreboot/+/35239/1/src/mainboard/google/hatch/... PS1, Line 34: echo <<EOF >variants/${variant,,}/include/variant/acpi/dptf.asl
Yeah, I don't especially like it either, but it was good-enough to get something started. […]
Since you are seeding this, you are setting the standard that people will use/copy. Since you already have python going, what about using that to copy template files and replace token like date and variant?
https://review.coreboot.org/c/coreboot/+/35239/1/src/mainboard/google/hatch/... PS1, Line 143: make sure the build includes GOOGLE_{variant^^} if we are keeping the git stuff, then we can use the -s option on git so we don't have to manually write the Signed-off-by line manually
git commit -sm "....."