Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Kangheui Won, Arthur Heymans, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52961 )
Change subject: cezanne/psp_verstage: populate a/b firmware
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/guybrush/Kconfig:
https://review.coreboot.org/c/coreboot/+/52961/comment/2dfa6b0c_ebfa1649
PS1, Line 74: config CEZANNE_FW_A_POSITION
: hex
: default 0xFF012040
: depends on VBOOT_SLOTS_RW_AB
: help
: Location of the AMD firmware in the RW_A region. This is the
: start of the RW-A region + 64 bytes for the cbfs header.
:
: config CEZANNE_FW_B_POSITION
: hex
: default 0xFF312040
: depends on VBOOT_SLOTS_RW_AB
: help
: Location of the AMD firmware in the RW_B region. This is the
: start of the RW-A region + 64 bytes for the cbfs header.
See Makefile.inc:133 for an example […]
Seems like a good plan.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52961
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb31afa7a513f01593b2af75515a170dfca8d360
Gerrit-Change-Number: 52961
Gerrit-PatchSet: 1
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 06 May 2021 19:13:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment